Skip to content

feat: better unknown account error #4166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

leohhhn
Copy link
Contributor

@leohhhn leohhhn commented Apr 15, 2025

Description

Fixes #4165

@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Apr 15, 2025
@Gno2D2 Gno2D2 added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Apr 15, 2025
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Apr 15, 2025

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)
🟢 Pending initial approval by a review team member, or review from tech-staff

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: leohhhn/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Pending initial approval by a review team member, or review from tech-staff

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 Not (🔴 Pull request author is a member of the team: tech-staff)

Then

🟢 Requirement satisfied
└── 🟢 If
    ├── 🟢 Condition
    │   └── 🟢 Or
    │       ├── 🔴 At least 1 user(s) of the organization reviewed the pull request (with state "APPROVED")
    │       ├── 🟢 At least 1 user(s) of the team tech-staff reviewed pull request
    │       └── 🔴 This pull request is a draft
    └── 🟢 Then
        └── 🟢 And
            ├── 🟢 Not (🔴 This label is applied to pull request: review/triage-pending)
            └── 🟢 At least 1 user(s) of the team tech-staff reviewed pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

Copy link

codecov bot commented Apr 15, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
gno.land/pkg/sdk/vm/keeper.go 0.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@Kouteki Kouteki requested a review from zivkovicmilos April 15, 2025 20:30
@Kouteki Kouteki moved this from Triage to In Review in 🧙‍♂️gno.land core team Apr 15, 2025
@leohhhn
Copy link
Contributor Author

leohhhn commented Apr 15, 2025

This PR covers Run & AddPkg messages; if the case I listed here is correct, we can change all occurences of the error in question to something better.

If not, I'll let someone else with more context handle this issue

@@ -336,7 +336,7 @@ func (vm *VMKeeper) AddPackage(ctx sdk.Context, msg MsgAddPackage) (err error) {
}
creatorAcc := vm.acck.GetAccount(ctx, creator)
if creatorAcc == nil {
return std.ErrUnknownAddress(fmt.Sprintf("account %s does not exist", creator))
return std.ErrUnknownAddress(fmt.Sprintf("account %s has not been initialized. does it have coins?", creator))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return std.ErrUnknownAddress(fmt.Sprintf("account %s has not been initialized. does it have coins?", creator))
return std.ErrUnknownAddress(fmt.Sprintf("account %s does not exist or has not been initialized. does it have coins?", creator))

We still want the error to make sense if an address doesn't exist at all.

@@ -575,7 +575,7 @@ func (vm *VMKeeper) Run(ctx sdk.Context, msg MsgRun) (res string, err error) {
// Validate arguments.
callerAcc := vm.acck.GetAccount(ctx, caller)
if callerAcc == nil {
return "", std.ErrUnknownAddress(fmt.Sprintf("account %s does not exist", caller))
return "", std.ErrUnknownAddress(fmt.Sprintf("account %s has not been initialized. does it have coins?", caller))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return "", std.ErrUnknownAddress(fmt.Sprintf("account %s has not been initialized. does it have coins?", caller))
return "", std.ErrUnknownAddress(fmt.Sprintf("account %s does not exist or has not been initialized. does it have coins?", caller))

@Gno2D2 Gno2D2 removed the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Apr 15, 2025
@@ -336,7 +336,7 @@ func (vm *VMKeeper) AddPackage(ctx sdk.Context, msg MsgAddPackage) (err error) {
}
creatorAcc := vm.acck.GetAccount(ctx, creator)
if creatorAcc == nil {
return std.ErrUnknownAddress(fmt.Sprintf("account %s does not exist", creator))
return std.ErrUnknownAddress(fmt.Sprintf("account %s has not been initialized. does it have coins?", creator))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a rhetorical question - accounts that don't exist don't have coins.

I'd prefer something like account %s does not exist, it must receive coins to be created so we point the user to a clearer problem and solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
Status: No status
Status: In Review
Development

Successfully merging this pull request may close these issues.

Uninitialized account error handling
4 participants